FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 1.2.1

Threshold is Low

Effort is Default

Summary

Classes Bugs Errors Missing Classes
629 175 0 0

Files

Class Bugs
org.opoo.dao.Entity 1
org.opoo.dao.hibernate3.HibernateQuerySupport$1 1
org.opoo.dao.hibernate3.HibernateQuerySupport$10 2
org.opoo.dao.hibernate3.HibernateQuerySupport$11 2
org.opoo.dao.hibernate3.HibernateQuerySupport$12 2
org.opoo.dao.hibernate3.HibernateQuerySupport$2 1
org.opoo.dao.hibernate3.HibernateQuerySupport$3 1
org.opoo.dao.hibernate3.HibernateQuerySupport$4 2
org.opoo.dao.hibernate3.HibernateQuerySupport$5 2
org.opoo.dao.hibernate3.HibernateQuerySupport$6 2
org.opoo.dao.hibernate3.HibernateQuerySupport$7 1
org.opoo.dao.hibernate3.HibernateQuerySupport$8 1
org.opoo.dao.hibernate3.HibernateQuerySupport$9 1
org.opoo.dao.support.PageableList 1
org.opoo.dao.support.Paginator 4
org.opoo.dao.support.ResultFilter 2
org.opoo.oqs.QueryHelper 1
org.opoo.oqs.QueryHolder 5
org.opoo.oqs.core.AbstractQuery 26
org.opoo.oqs.core.AbstractQueryFactory 2
org.opoo.oqs.core.DefaultQueryTranslator 3
org.opoo.oqs.core.DefaultSelectParser$SelectParserUtils 5
org.opoo.oqs.core.IteratorResultSetHandler 1
org.opoo.oqs.core.mapper.AbstractMultiPropertyMapper 3
org.opoo.oqs.core.mapper.AsteriskPropertyMapper 3
org.opoo.oqs.core.mapper.BeanPropertyMapper 1
org.opoo.oqs.criterion.In 4
org.opoo.oqs.criterion.Logic 6
org.opoo.oqs.criterion.NotNull 3
org.opoo.oqs.criterion.Null 3
org.opoo.oqs.criterion.Order$OrderIterator 1
org.opoo.oqs.criterion.SimpleExpression 1
org.opoo.oqs.criterion.SqlCriterion 7
org.opoo.oqs.dialect.HSQLDialect 1
org.opoo.oqs.dialect.Oracle9Dialect 1
org.opoo.oqs.dialect.SQLServerDialect 1
org.opoo.oqs.spring.SpringBatcher$1 1
org.opoo.oqs.spring.SpringQuery$1 1
org.opoo.oqs.spring.SpringQuery$2 1
org.opoo.oqs.spring.SpringQueryFactory$1 1
org.opoo.oqs.spring.jdbc.ArgPreparedStatementSetter 2
org.opoo.oqs.spring.jdbc.ArgTypePreparedStatementSetter 2
org.opoo.oqs.spring.jdbc.SimplePreparedStatementCreator 1
org.opoo.oqs.spring.transaction.SpringJdbcTransaction 1
org.opoo.oqs.type.AnyType 1
org.opoo.oqs.type.BigDecimalType 1
org.opoo.oqs.type.BigIntegerType 1
org.opoo.oqs.type.BinaryType 1
org.opoo.oqs.type.BlobType 1
org.opoo.oqs.type.BooleanType 1
org.opoo.oqs.type.ByteType 4
org.opoo.oqs.type.CalendarDateType 1
org.opoo.oqs.type.CalendarType 1
org.opoo.oqs.type.CharacterType 2
org.opoo.oqs.type.ClassType 1
org.opoo.oqs.type.ClobType 1
org.opoo.oqs.type.CurrencyType 4
org.opoo.oqs.type.DateType 1
org.opoo.oqs.type.DoubleType 4
org.opoo.oqs.type.FloatType 3
org.opoo.oqs.type.IntegerType 4
org.opoo.oqs.type.LocaleType 2
org.opoo.oqs.type.LongType 4
org.opoo.oqs.type.SerializableType 2
org.opoo.oqs.type.ShortType 4
org.opoo.oqs.type.StringType 1
org.opoo.oqs.type.TextType 1
org.opoo.oqs.type.TimeType 1
org.opoo.oqs.type.TimeZoneType 1
org.opoo.oqs.type.TimestampType 1
org.opoo.oqs.type.TrueFalseType 1
org.opoo.oqs.type.YesNoType 1
org.opoo.util.ClassUtils 4
org.opoo.util.ClassUtils$BeanInvocationHandler 2
org.opoo.util.ClassUtils$PackageClassLoader 1
org.opoo.util.StringUtils 3

org.opoo.dao.Entity

Bug Category Details Line
org.opoo.dao.Entity is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 31-43

org.opoo.dao.hibernate3.HibernateQuerySupport$1

Bug Category Details Line
The class org.opoo.dao.hibernate3.HibernateQuerySupport$1 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON 45-48

org.opoo.dao.hibernate3.HibernateQuerySupport$10

Bug Category Details Line
Method org.opoo.dao.hibernate3.HibernateQuerySupport$10.doInHibernate(Session) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 170
The class org.opoo.dao.hibernate3.HibernateQuerySupport$10 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON 167-170

org.opoo.dao.hibernate3.HibernateQuerySupport$11

Bug Category Details Line
Method org.opoo.dao.hibernate3.HibernateQuerySupport$11.doInHibernate(Session) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 181
The class org.opoo.dao.hibernate3.HibernateQuerySupport$11 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON 178-181

org.opoo.dao.hibernate3.HibernateQuerySupport$12

Bug Category Details Line
Method org.opoo.dao.hibernate3.HibernateQuerySupport$12.doInHibernate(Session) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 192
The class org.opoo.dao.hibernate3.HibernateQuerySupport$12 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON 189-192

org.opoo.dao.hibernate3.HibernateQuerySupport$2

Bug Category Details Line
The class org.opoo.dao.hibernate3.HibernateQuerySupport$2 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON 55-65

org.opoo.dao.hibernate3.HibernateQuerySupport$3

Bug Category Details Line
The class org.opoo.dao.hibernate3.HibernateQuerySupport$3 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON 79-82

org.opoo.dao.hibernate3.HibernateQuerySupport$4

Bug Category Details Line
Method org.opoo.dao.hibernate3.HibernateQuerySupport$4.doInHibernate(Session) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 104
The class org.opoo.dao.hibernate3.HibernateQuerySupport$4 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON 100-104

org.opoo.dao.hibernate3.HibernateQuerySupport$5

Bug Category Details Line
Method org.opoo.dao.hibernate3.HibernateQuerySupport$5.doInHibernate(Session) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 115
The class org.opoo.dao.hibernate3.HibernateQuerySupport$5 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON 110-115

org.opoo.dao.hibernate3.HibernateQuerySupport$6

Bug Category Details Line
Method org.opoo.dao.hibernate3.HibernateQuerySupport$6.doInHibernate(Session) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 126
The class org.opoo.dao.hibernate3.HibernateQuerySupport$6 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON 121-126

org.opoo.dao.hibernate3.HibernateQuerySupport$7

Bug Category Details Line
The class org.opoo.dao.hibernate3.HibernateQuerySupport$7 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON 134-137

org.opoo.dao.hibernate3.HibernateQuerySupport$8

Bug Category Details Line
The class org.opoo.dao.hibernate3.HibernateQuerySupport$8 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON 145-148

org.opoo.dao.hibernate3.HibernateQuerySupport$9

Bug Category Details Line
The class org.opoo.dao.hibernate3.HibernateQuerySupport$9 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON 156-159

org.opoo.dao.support.PageableList

Bug Category Details Line
org.opoo.dao.support.PageableList is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 33-88

org.opoo.dao.support.Paginator

Bug Category Details Line
org.opoo.dao.support.Paginator.getPages() may expose internal representation by returning Paginator.pages MALICIOUS_CODE EI_EXPOSE_REP 172
org.opoo.dao.support.Paginator.getPages(int) may expose internal representation by returning Paginator.pages MALICIOUS_CODE EI_EXPOSE_REP 224
Method org.opoo.dao.support.Paginator.getPages() uses Collection.toArray() with zero-length array argument PERFORMANCE ITA_INEFFICIENT_TO_ARRAY 169
Method org.opoo.dao.support.Paginator.getPages(int) uses Collection.toArray() with zero-length array argument PERFORMANCE ITA_INEFFICIENT_TO_ARRAY 222

org.opoo.dao.support.ResultFilter

Bug Category Details Line
org.opoo.dao.support.ResultFilter.MAX_RESULTS isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 33
Static initializer for org.opoo.dao.support.ResultFilter creates instance before all static final fields assigned BAD_PRACTICE SI_INSTANCE_BEFORE_FINALS_ASSIGNED 31

org.opoo.oqs.QueryHelper

Bug Category Details Line
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 57

org.opoo.oqs.QueryHolder

Bug Category Details Line
org.opoo.oqs.QueryHolder.addBoolean(boolean) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead PERFORMANCE DM_BOOLEAN_CTOR 90
Method org.opoo.oqs.QueryHolder.addInt(int) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 82
Method org.opoo.oqs.QueryHolder.addLong(long) invokes inefficient Long(long) constructor; use Long.valueOf(long) instead PERFORMANCE DM_NUMBER_CTOR 86
Exception is caught when Exception is not thrown in org.opoo.oqs.QueryHolder.toString() STYLE REC_CATCH_EXCEPTION 150
org.opoo.oqs.QueryHolder is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 39-181

org.opoo.oqs.core.AbstractQuery

Bug Category Details Line
Dead store to clazz in org.opoo.oqs.core.AbstractQuery.setProperties(Object) STYLE DLS_DEAD_LOCAL_STORE 1037
Dead store to i in org.opoo.oqs.core.AbstractQuery.verifyPositionalParametersAfterProcessSQL() STYLE DLS_DEAD_LOCAL_STORE 382
Dead store to i in org.opoo.oqs.core.AbstractQuery.verifyPositionalParametersAfterProcessSQL() STYLE DLS_DEAD_LOCAL_STORE 381
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 208
Method org.opoo.oqs.core.AbstractQuery.setDouble(int, double) invokes inefficient Double(double) constructor; use Double.valueOf(double) instead PERFORMANCE DM_FP_NUMBER_CTOR 742
Method org.opoo.oqs.core.AbstractQuery.setDouble(String, double) invokes inefficient Double(double) constructor; use Double.valueOf(double) instead PERFORMANCE DM_FP_NUMBER_CTOR 822
Method org.opoo.oqs.core.AbstractQuery.setFloat(int, float) invokes inefficient Float(float) constructor; use Float.valueOf(float) instead PERFORMANCE DM_FP_NUMBER_CTOR 737
Method org.opoo.oqs.core.AbstractQuery.setFloat(String, float) invokes inefficient Float(float) constructor; use Float.valueOf(float) instead PERFORMANCE DM_FP_NUMBER_CTOR 827
Method org.opoo.oqs.core.AbstractQuery.appendLimitParameters() invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 561
Method org.opoo.oqs.core.AbstractQuery.appendLimitParameters() invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 562
Method org.opoo.oqs.core.AbstractQuery.setByte(int, byte) invokes inefficient Byte(byte) constructor; use Byte.valueOf(byte) instead PERFORMANCE DM_NUMBER_CTOR 717
Method org.opoo.oqs.core.AbstractQuery.setByte(String, byte) invokes inefficient Byte(byte) constructor; use Byte.valueOf(byte) instead PERFORMANCE DM_NUMBER_CTOR 807
Method org.opoo.oqs.core.AbstractQuery.setCharacter(int, char) invokes inefficient Character(char) constructor; use Character.valueOf(char) instead PERFORMANCE DM_NUMBER_CTOR 706
Method org.opoo.oqs.core.AbstractQuery.setCharacter(String, char) invokes inefficient Character(char) constructor; use Character.valueOf(char) instead PERFORMANCE DM_NUMBER_CTOR 812
Method org.opoo.oqs.core.AbstractQuery.setInteger(int, int) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 727
Method org.opoo.oqs.core.AbstractQuery.setInteger(String, int) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 832
Method org.opoo.oqs.core.AbstractQuery.setLong(int, long) invokes inefficient Long(long) constructor; use Long.valueOf(long) instead PERFORMANCE DM_NUMBER_CTOR 732
Method org.opoo.oqs.core.AbstractQuery.setLong(String, long) invokes inefficient Long(long) constructor; use Long.valueOf(long) instead PERFORMANCE DM_NUMBER_CTOR 852
Method org.opoo.oqs.core.AbstractQuery.setShort(int, short) invokes inefficient Short(short) constructor; use Short.valueOf(short) instead PERFORMANCE DM_NUMBER_CTOR 722
Method org.opoo.oqs.core.AbstractQuery.setShort(String, short) invokes inefficient Short(short) constructor; use Short.valueOf(short) instead PERFORMANCE DM_NUMBER_CTOR 873
Load of known null value in org.opoo.oqs.core.AbstractQuery.getGeneratedIdentity(ResultSet) STYLE NP_LOAD_OF_KNOWN_NULL_VALUE 1445
Load of known null value in org.opoo.oqs.core.AbstractQuery.getInsertSelectIdentity(String) STYLE NP_LOAD_OF_KNOWN_NULL_VALUE 1329
Load of known null value in org.opoo.oqs.core.AbstractQuery.setParameter(int, Object) STYLE NP_LOAD_OF_KNOWN_NULL_VALUE 914
Load of known null value in org.opoo.oqs.core.AbstractQuery.setParameter(String, Object) STYLE NP_LOAD_OF_KNOWN_NULL_VALUE 923
Should org.opoo.oqs.core.AbstractQuery.getReturnAliases() return a zero length array rather than null? STYLE PZLA_PREFER_ZERO_LENGTH_ARRAYS 941
Should org.opoo.oqs.core.AbstractQuery.getReturnTypes() return a zero length array rather than null? STYLE PZLA_PREFER_ZERO_LENGTH_ARRAYS 937

org.opoo.oqs.core.AbstractQueryFactory

Bug Category Details Line
org.opoo.oqs.core.AbstractQueryFactory.setBeanImports(String[]) creates a org.opoo.oqs.core.BeanClassLoader classloader, which should be performed within a doPrivileged block BAD_PRACTICE DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED 162
Exception is caught when Exception is not thrown in org.opoo.oqs.core.AbstractQueryFactory.determineDialect(String, int) STYLE REC_CATCH_EXCEPTION 260

org.opoo.oqs.core.DefaultQueryTranslator

Bug Category Details Line
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 45
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 101
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 132

org.opoo.oqs.core.DefaultSelectParser$SelectParserUtils

Bug Category Details Line
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 263
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 197
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 135
Method org.opoo.oqs.core.DefaultSelectParser$SelectParserUtils.createProperty2(String) concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 247
Method org.opoo.oqs.core.DefaultSelectParser$SelectParserUtils.parsePropertyMappers(String, DefaultSelectParser$SelectParserUtils$Index, ClassLoader) concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 144

org.opoo.oqs.core.IteratorResultSetHandler

Bug Category Details Line
Unread field: org.opoo.oqs.core.IteratorResultSetHandler.mapper PERFORMANCE URF_UNREAD_FIELD 1494

org.opoo.oqs.core.mapper.AbstractMultiPropertyMapper

Bug Category Details Line
Dead store of null to list in org.opoo.oqs.core.mapper.AbstractMultiPropertyMapper.initialize(ResultSetMetaData) STYLE DLS_DEAD_LOCAL_STORE_OF_NULL 90
org.opoo.oqs.core.mapper.AbstractMultiPropertyMapper.AbstractMultiPropertyMapper(String, String, PropertyMapper[]) may expose internal representation by storing an externally mutable object into AbstractMultiPropertyMapper.mappers MALICIOUS_CODE EI_EXPOSE_REP2 46
org.opoo.oqs.core.mapper.AbstractMultiPropertyMapper.AbstractMultiPropertyMapper(Property, PropertyMapper[]) may expose internal representation by storing an externally mutable object into AbstractMultiPropertyMapper.mappers MALICIOUS_CODE EI_EXPOSE_REP2 51

org.opoo.oqs.core.mapper.AsteriskPropertyMapper

Bug Category Details Line
org.opoo.oqs.core.mapper.AsteriskPropertyMapper.getSinglePropertyMappers() may expose internal representation by returning AsteriskPropertyMapper.singlePropertyMappers MALICIOUS_CODE EI_EXPOSE_REP 94
Class org.opoo.oqs.core.mapper.AsteriskPropertyMapper implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES 37-153
Private method org.opoo.oqs.core.mapper.AsteriskPropertyMapper.createSinglePropertyMappers2() is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 111-137

org.opoo.oqs.core.mapper.BeanPropertyMapper

Bug Category Details Line
Redundant nullcheck of target, which is known to be non-null in org.opoo.oqs.core.mapper.BeanPropertyMapper.map(ResultSet, int) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 82

org.opoo.oqs.criterion.In

Bug Category Details Line
org.opoo.oqs.criterion.In.getTypes() may expose internal representation by returning In.types MALICIOUS_CODE EI_EXPOSE_REP 74
org.opoo.oqs.criterion.In.getValues() may expose internal representation by returning In.values MALICIOUS_CODE EI_EXPOSE_REP 66
org.opoo.oqs.criterion.In.In(String, Object[], Type) may expose internal representation by storing an externally mutable object into In.values MALICIOUS_CODE EI_EXPOSE_REP2 45
org.opoo.oqs.criterion.In is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 33-74

org.opoo.oqs.criterion.Logic

Bug Category Details Line
org.opoo.oqs.criterion.Logic.getTypes() may expose internal representation by returning Logic.types MALICIOUS_CODE EI_EXPOSE_REP 120
org.opoo.oqs.criterion.Logic.getValues() may expose internal representation by returning Logic.values MALICIOUS_CODE EI_EXPOSE_REP 106
org.opoo.oqs.criterion.Logic.toString() may return null BAD_PRACTICE NP_TOSTRING_COULD_RETURN_NULL 111
Should org.opoo.oqs.criterion.Logic.getTypes() return a zero length array rather than null? STYLE PZLA_PREFER_ZERO_LENGTH_ARRAYS 118
Should org.opoo.oqs.criterion.Logic.getValues() return a zero length array rather than null? STYLE PZLA_PREFER_ZERO_LENGTH_ARRAYS 104
org.opoo.oqs.criterion.Logic is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 34-120

org.opoo.oqs.criterion.NotNull

Bug Category Details Line
Should org.opoo.oqs.criterion.NotNull.getTypes() return a zero length array rather than null? STYLE PZLA_PREFER_ZERO_LENGTH_ARRAYS 45
Should org.opoo.oqs.criterion.NotNull.getValues() return a zero length array rather than null? STYLE PZLA_PREFER_ZERO_LENGTH_ARRAYS 37
org.opoo.oqs.criterion.NotNull is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 31-45

org.opoo.oqs.criterion.Null

Bug Category Details Line
Should org.opoo.oqs.criterion.Null.getTypes() return a zero length array rather than null? STYLE PZLA_PREFER_ZERO_LENGTH_ARRAYS 46
Should org.opoo.oqs.criterion.Null.getValues() return a zero length array rather than null? STYLE PZLA_PREFER_ZERO_LENGTH_ARRAYS 38
org.opoo.oqs.criterion.Null is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 32-46

org.opoo.oqs.criterion.Order$OrderIterator

Bug Category Details Line
org.opoo.oqs.criterion.Order$OrderIterator.next() can't throw NoSuchElement exception BAD_PRACTICE IT_NO_SUCH_ELEMENT 128

org.opoo.oqs.criterion.SimpleExpression

Bug Category Details Line
org.opoo.oqs.criterion.SimpleExpression is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 34-57

org.opoo.oqs.criterion.SqlCriterion

Bug Category Details Line
Dead store of null to values in org.opoo.oqs.criterion.SqlCriterion.SqlCriterion(String, Object[]) STYLE DLS_DEAD_LOCAL_STORE_OF_NULL 44
org.opoo.oqs.criterion.SqlCriterion.getTypes() may expose internal representation by returning SqlCriterion.types MALICIOUS_CODE EI_EXPOSE_REP 67
org.opoo.oqs.criterion.SqlCriterion.getValues() may expose internal representation by returning SqlCriterion.values MALICIOUS_CODE EI_EXPOSE_REP 59
org.opoo.oqs.criterion.SqlCriterion.SqlCriterion(String, Object[]) may expose internal representation by storing an externally mutable object into SqlCriterion.values MALICIOUS_CODE EI_EXPOSE_REP2 36
org.opoo.oqs.criterion.SqlCriterion.SqlCriterion(String, Object[], Type[]) may expose internal representation by storing an externally mutable object into SqlCriterion.types MALICIOUS_CODE EI_EXPOSE_REP2 54
org.opoo.oqs.criterion.SqlCriterion.SqlCriterion(String, Object[], Type[]) may expose internal representation by storing an externally mutable object into SqlCriterion.values MALICIOUS_CODE EI_EXPOSE_REP2 53
org.opoo.oqs.criterion.SqlCriterion is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 33-67

org.opoo.oqs.dialect.HSQLDialect

Bug Category Details Line
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 45

org.opoo.oqs.dialect.Oracle9Dialect

Bug Category Details Line
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 37

org.opoo.oqs.dialect.SQLServerDialect

Bug Category Details Line
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 29

org.opoo.oqs.spring.SpringBatcher$1

Bug Category Details Line
The class org.opoo.oqs.spring.SpringBatcher$1 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON 55-66

org.opoo.oqs.spring.SpringQuery$1

Bug Category Details Line
The class org.opoo.oqs.spring.SpringQuery$1 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON 67-70

org.opoo.oqs.spring.SpringQuery$2

Bug Category Details Line
Method org.opoo.oqs.spring.SpringQuery$2.doInCallableStatement(CallableStatement) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 152

org.opoo.oqs.spring.SpringQueryFactory$1

Bug Category Details Line
The class org.opoo.oqs.spring.SpringQueryFactory$1 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON 103-109

org.opoo.oqs.spring.jdbc.ArgPreparedStatementSetter

Bug Category Details Line
org.opoo.oqs.spring.jdbc.ArgPreparedStatementSetter.ArgPreparedStatementSetter(Object[]) may expose internal representation by storing an externally mutable object into ArgPreparedStatementSetter.args MALICIOUS_CODE EI_EXPOSE_REP2 51
Load of known null value in org.opoo.oqs.spring.jdbc.ArgPreparedStatementSetter.setParameter(PreparedStatement, Object, int) STYLE NP_LOAD_OF_KNOWN_NULL_VALUE 81

org.opoo.oqs.spring.jdbc.ArgTypePreparedStatementSetter

Bug Category Details Line
org.opoo.oqs.spring.jdbc.ArgTypePreparedStatementSetter.ArgTypePreparedStatementSetter(Object[], Type[]) may expose internal representation by storing an externally mutable object into ArgTypePreparedStatementSetter.args MALICIOUS_CODE EI_EXPOSE_REP2 57
org.opoo.oqs.spring.jdbc.ArgTypePreparedStatementSetter.ArgTypePreparedStatementSetter(Object[], Type[]) may expose internal representation by storing an externally mutable object into ArgTypePreparedStatementSetter.types MALICIOUS_CODE EI_EXPOSE_REP2 58

org.opoo.oqs.spring.jdbc.SimplePreparedStatementCreator

Bug Category Details Line
A prepared statement is generated from a nonconstant String at org.opoo.oqs.spring.jdbc.SimplePreparedStatementCreator.createPreparedStatement(Connection) BAD_PRACTICE SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING 58

org.opoo.oqs.spring.transaction.SpringJdbcTransaction

Bug Category Details Line
Class org.opoo.oqs.spring.transaction.SpringJdbcTransaction implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES 42-89

org.opoo.oqs.type.AnyType

Bug Category Details Line
org.opoo.oqs.type.AnyType is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 35-81

org.opoo.oqs.type.BigDecimalType

Bug Category Details Line
org.opoo.oqs.type.BigDecimalType is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 33-63

org.opoo.oqs.type.BigIntegerType

Bug Category Details Line
org.opoo.oqs.type.BigIntegerType is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 33-71

org.opoo.oqs.type.BinaryType

Bug Category Details Line
org.opoo.oqs.type.BinaryType is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 31-80

org.opoo.oqs.type.BlobType

Bug Category Details Line
org.opoo.oqs.type.BlobType is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 32-74

org.opoo.oqs.type.BooleanType

Bug Category Details Line
org.opoo.oqs.type.BooleanType is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 32-70

org.opoo.oqs.type.ByteType

Bug Category Details Line
Method org.opoo.oqs.type.ByteType.<static initializer>() invokes inefficient Byte(byte) constructor; use Byte.valueOf(byte) instead PERFORMANCE DM_NUMBER_CTOR 34
Method org.opoo.oqs.type.ByteType.get(ResultSet, int) invokes inefficient Byte(byte) constructor; use Byte.valueOf(byte) instead PERFORMANCE DM_NUMBER_CTOR 45
Method org.opoo.oqs.type.ByteType.get(ResultSet, String) invokes inefficient Byte(byte) constructor; use Byte.valueOf(byte) instead PERFORMANCE DM_NUMBER_CTOR 41
org.opoo.oqs.type.ByteType is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 32-70

org.opoo.oqs.type.CalendarDateType

Bug Category Details Line
org.opoo.oqs.type.CalendarDateType is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 35-84

org.opoo.oqs.type.CalendarType

Bug Category Details Line
org.opoo.oqs.type.CalendarType is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 36-90

org.opoo.oqs.type.CharacterType

Bug Category Details Line
Method org.opoo.oqs.type.CharacterType.valueOf(String) invokes inefficient Character(char) constructor; use Character.valueOf(char) instead PERFORMANCE DM_NUMBER_CTOR 35
org.opoo.oqs.type.CharacterType is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 32-82

org.opoo.oqs.type.ClassType

Bug Category Details Line
org.opoo.oqs.type.ClassType is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 30-100

org.opoo.oqs.type.ClobType

Bug Category Details Line
org.opoo.oqs.type.ClobType is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 32-76

org.opoo.oqs.type.CurrencyType

Bug Category Details Line
Exception is caught when Exception is not thrown in org.opoo.oqs.type.CurrencyType.<static initializer>() STYLE REC_CATCH_EXCEPTION 56
Exception is caught when Exception is not thrown in org.opoo.oqs.type.CurrencyType.result(ResultSet, String) STYLE REC_CATCH_EXCEPTION 88
Exception is caught when Exception is not thrown in org.opoo.oqs.type.CurrencyType.valueOf(String) STYLE REC_CATCH_EXCEPTION 67
org.opoo.oqs.type.CurrencyType is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 33-132

org.opoo.oqs.type.DateType

Bug Category Details Line
org.opoo.oqs.type.DateType is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 34-74

org.opoo.oqs.type.DoubleType

Bug Category Details Line
Method org.opoo.oqs.type.DoubleType.get(ResultSet, int) invokes inefficient Double(double) constructor; use Double.valueOf(double) instead PERFORMANCE DM_FP_NUMBER_CTOR 45
Method org.opoo.oqs.type.DoubleType.get(ResultSet, String) invokes inefficient Double(double) constructor; use Double.valueOf(double) instead PERFORMANCE DM_FP_NUMBER_CTOR 41
Method org.opoo.oqs.type.DoubleType.getDefaultValue() invokes inefficient Double(double) constructor; use Double.valueOf(double) instead PERFORMANCE DM_FP_NUMBER_CTOR 49
org.opoo.oqs.type.DoubleType is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 32-74

org.opoo.oqs.type.FloatType

Bug Category Details Line
Method org.opoo.oqs.type.FloatType.get(ResultSet, int) invokes inefficient Float(float) constructor; use Float.valueOf(float) instead PERFORMANCE DM_FP_NUMBER_CTOR 44
Method org.opoo.oqs.type.FloatType.get(ResultSet, String) invokes inefficient Float(float) constructor; use Float.valueOf(float) instead PERFORMANCE DM_FP_NUMBER_CTOR 40
org.opoo.oqs.type.FloatType is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 32-74

org.opoo.oqs.type.IntegerType

Bug Category Details Line
Method org.opoo.oqs.type.IntegerType.<static initializer>() invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 33
Method org.opoo.oqs.type.IntegerType.get(ResultSet, int) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 46
Method org.opoo.oqs.type.IntegerType.get(ResultSet, String) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 42
org.opoo.oqs.type.IntegerType is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 32-75

org.opoo.oqs.type.LocaleType

Bug Category Details Line
Method org.opoo.oqs.type.LocaleType.valueOf(String) concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 46
org.opoo.oqs.type.LocaleType is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 32-82

org.opoo.oqs.type.LongType

Bug Category Details Line
Method org.opoo.oqs.type.LongType.<static initializer>() invokes inefficient Long(long) constructor; use Long.valueOf(long) instead PERFORMANCE DM_NUMBER_CTOR 33
Method org.opoo.oqs.type.LongType.get(ResultSet, int) invokes inefficient Long(long) constructor; use Long.valueOf(long) instead PERFORMANCE DM_NUMBER_CTOR 46
Method org.opoo.oqs.type.LongType.get(ResultSet, String) invokes inefficient Long(long) constructor; use Long.valueOf(long) instead PERFORMANCE DM_NUMBER_CTOR 42
org.opoo.oqs.type.LongType is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 32-75

org.opoo.oqs.type.SerializableType

Bug Category Details Line
org.opoo.oqs.type.SerializableType.deserialize(InputStream) might ignore java.io.IOException BAD_PRACTICE DE_MIGHT_IGNORE 85
org.opoo.oqs.type.SerializableType is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 43-170

org.opoo.oqs.type.ShortType

Bug Category Details Line
Method org.opoo.oqs.type.ShortType.<static initializer>() invokes inefficient Short(short) constructor; use Short.valueOf(short) instead PERFORMANCE DM_NUMBER_CTOR 33
Method org.opoo.oqs.type.ShortType.get(ResultSet, int) invokes inefficient Short(short) constructor; use Short.valueOf(short) instead PERFORMANCE DM_NUMBER_CTOR 46
Method org.opoo.oqs.type.ShortType.get(ResultSet, String) invokes inefficient Short(short) constructor; use Short.valueOf(short) instead PERFORMANCE DM_NUMBER_CTOR 42
org.opoo.oqs.type.ShortType is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 32-76

org.opoo.oqs.type.StringType

Bug Category Details Line
org.opoo.oqs.type.StringType is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 31-66

org.opoo.oqs.type.TextType

Bug Category Details Line
org.opoo.oqs.type.TextType is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 34-105

org.opoo.oqs.type.TimeType

Bug Category Details Line
org.opoo.oqs.type.TimeType is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 35-79

org.opoo.oqs.type.TimeZoneType

Bug Category Details Line
org.opoo.oqs.type.TimeZoneType is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 33-72

org.opoo.oqs.type.TimestampType

Bug Category Details Line
org.opoo.oqs.type.TimestampType is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 35-82

org.opoo.oqs.type.TrueFalseType

Bug Category Details Line
org.opoo.oqs.type.TrueFalseType is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 28-38

org.opoo.oqs.type.YesNoType

Bug Category Details Line
org.opoo.oqs.type.YesNoType is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 28-36

org.opoo.util.ClassUtils

Bug Category Details Line
org.opoo.util.ClassUtils.createPackageClassLoader(String[]) creates a org.opoo.util.ClassUtils$PackageClassLoader classloader, which should be performed within a doPrivileged block BAD_PRACTICE DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED 472
Exception is caught when Exception is not thrown in org.opoo.util.ClassUtils.getConstantValue(String) STYLE REC_CATCH_EXCEPTION 115
Exception is caught when Exception is not thrown in org.opoo.util.ClassUtils.getMethod(Class, Method) STYLE REC_CATCH_EXCEPTION 139
Exception is caught when Exception is not thrown in org.opoo.util.ClassUtils.getSimpleName(Class) STYLE REC_CATCH_EXCEPTION 234

org.opoo.util.ClassUtils$BeanInvocationHandler

Bug Category Details Line
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 367
Method org.opoo.util.ClassUtils$BeanInvocationHandler.invoke(Object, Method, Object[]) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 352

org.opoo.util.ClassUtils$PackageClassLoader

Bug Category Details Line
org.opoo.util.ClassUtils$PackageClassLoader.setImports(String[]) may expose internal representation by storing an externally mutable object into ClassUtils$PackageClassLoader.imports MALICIOUS_CODE EI_EXPOSE_REP2 434

org.opoo.util.StringUtils

Bug Category Details Line
Primitive value is boxed then unboxed to perform primative coercion in org.opoo.util.StringUtils.decodeHex(String) PERFORMANCE BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION 243
Method org.opoo.util.StringUtils.decodeHex(String) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 243
Check for oddness that won't work for negative numbers in org.opoo.util.StringUtils.left2(String, String, int) STYLE IM_BAD_CHECK_FOR_ODD 104